Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.15.z] verify host owner name after host registration #15402

Merged
merged 1 commit into from
Jan 8, 2025
Merged

[6.15.z] verify host owner name after host registration #15402

merged 1 commit into from
Jan 8, 2025

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #15178

Problem Statement

When a host is registered, its Owner is not set to the admin that generated the registration command. It stays set to a hidden API user, Owner is displayed as Anonymous Admin.

The user who actually ran the registration process should be set as owner.

Solution

The following automation script is designed to verify that the host is registered correctly and that it is assigned the expected owner name as specified.

@Satellite-QE Satellite-QE requested a review from a team as a code owner June 13, 2024 15:42
@Satellite-QE Satellite-QE added 6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Jun 13, 2024
@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Jun 13, 2024
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 7389
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_registration.py -k test_host_registration_end_to_end --external-logging
Test Result : ========== 6 failed, 9 deselected, 522 warnings in 3746.04s (1:02:26) ==========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jun 13, 2024
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 7392
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_registration.py -k test_host_registration_end_to_end --external-logging
Test Result : ========== 6 failed, 9 deselected, 533 warnings in 3807.97s (1:03:27) ==========

@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 7394
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_registration.py -k test_host_registration_end_to_end --external-logging
Test Result : ========== 6 failed, 9 deselected, 489 warnings in 3369.37s (0:56:09) ==========

@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 7436
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_registration.py -k test_host_registration_end_to_end --external-logging
Test Result : ========== 6 failed, 9 deselected, 480 warnings in 3312.08s (0:55:12) ==========

@Gauravtalreja1 Gauravtalreja1 force-pushed the cherry-pick-6.15.z-423864f72c811278e59bc2160247018ec2e4b4be branch from 42d880f to 9815ec0 Compare June 21, 2024 19:16
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 7480
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_registration.py -k test_host_registration_end_to_end --external-logging
Test Result : ========== 6 failed, 9 deselected, 507 warnings in 3537.93s (0:58:57) ==========

@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 7482
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_registration.py -k test_host_registration_end_to_end --external-logging
Test Result : ========== 6 failed, 9 deselected, 492 warnings in 3466.19s (0:57:46) ==========

@Gauravtalreja1
Copy link
Collaborator

@amolpati30 Can you investigate the PRT failures, and update the PR?

@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 7670
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_registration.py -k test_host_registration_end_to_end --external-logging
Test Result : ========== 6 failed, 9 deselected, 526 warnings in 3536.43s (0:58:56) ==========

@Gauravtalreja1
Copy link
Collaborator

@amolpati30 Could you please update this PR?

@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 8175
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_registration.py -k test_host_registration_end_to_end --external-logging
Test Result : ===== 5 failed, 9 deselected, 781 warnings, 1 error in 6001.05s (1:40:01) ======

@shweta83
Copy link
Contributor

@amolpati30 Can you please rebase the PR and check the failure?

@amolpati30 amolpati30 force-pushed the cherry-pick-6.15.z-423864f72c811278e59bc2160247018ec2e4b4be branch from 9815ec0 to e8ddfac Compare January 3, 2025 08:14
@amolpati30 amolpati30 removed Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing labels Jan 3, 2025
@SatelliteQE SatelliteQE deleted a comment from Satellite-QE Jan 3, 2025
@SatelliteQE SatelliteQE deleted a comment from Gauravtalreja1 Jan 3, 2025
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 9742
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_registration.py -k test_host_registration_end_to_end --external-logging
Test Result : ========== 6 failed, 9 deselected, 522 warnings in 3446.30s (0:57:26) ==========

@amolpati30 amolpati30 force-pushed the cherry-pick-6.15.z-423864f72c811278e59bc2160247018ec2e4b4be branch from e8ddfac to bfa7d10 Compare January 3, 2025 12:14
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 9745
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_registration.py -k test_host_registration_end_to_end --external-logging
Test Result : =========== 9 deselected, 63 warnings, 6 errors in 930.99s (0:15:30) ===========

@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 9748
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_registration.py -k test_host_registration_end_to_end --external-logging
Test Result : ========== 6 failed, 9 deselected, 503 warnings in 3376.91s (0:56:16) ==========

@amolpati30 amolpati30 force-pushed the cherry-pick-6.15.z-423864f72c811278e59bc2160247018ec2e4b4be branch from bfa7d10 to ae5f40a Compare January 3, 2025 15:33
@amolpati30 amolpati30 force-pushed the cherry-pick-6.15.z-423864f72c811278e59bc2160247018ec2e4b4be branch from ae5f40a to 4a23192 Compare January 3, 2025 15:35
@Satellite-QE @pre-commit-ci @amolpati30
[6.15.z] [pre-commit.ci] pre-commit autoupdate (#17233)
cf8533b 
[pre-commit.ci] pre-commit autoupdate (#17231)

updates:
- [github.com/gitleaks/gitleaks: v8.22.0 → v8.22.1](gitleaks/gitleaks@v8.22.0...v8.22.1)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 1f7402b)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@amolpati30 amolpati30 force-pushed the cherry-pick-6.15.z-423864f72c811278e59bc2160247018ec2e4b4be branch from 4a23192 to cf8533b Compare January 3, 2025 15:36
@SatelliteQE SatelliteQE deleted a comment from lhellebr Jan 3, 2025
@amolpati30
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/cli/test_registration.py -k test_host_registration_end_to_end

@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 9752
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_registration.py -k test_host_registration_end_to_end --external-logging
Test Result : ========== 1 passed, 9 deselected, 26 warnings in 1693.43s (0:28:13) ===========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Jan 3, 2025
@amolpati30 amolpati30 requested a review from a team January 3, 2025 17:21
@Gauravtalreja1 Gauravtalreja1 merged commit a86aacd into 6.15.z Jan 8, 2025
13 checks passed
@Gauravtalreja1 Gauravtalreja1 deleted the cherry-pick-6.15.z-423864f72c811278e59bc2160247018ec2e4b4be branch January 8, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

@shweta83 shweta83 shweta83 approved these changes

Assignees

@Satellite-QE Satellite-QE

@amolpati30 amolpati30

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Satellite-QE @Gauravtalreja1 @shweta83 @amolpati30